linux-kernel - Re: [RFC 2/3] module: Ignore delete

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPcyv4gS9Hp_4v0iybrNzj6pod7F1+9iQcOT6Sw=5xt0=-u=jA@mail.gmail.com>
Date:   Wed, 27 Sep 2017 23:03:39 -0700
From:   Dan Williams <dan.j.williams@...el.com>
To:     Jon Derrick <jonathan.derrick@...el.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Bjorn Helgaas <helgaas@...nel.org>, linux-pci@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Alan Cox <alan@...ux.intel.com>
Subject: Re: [RFC 2/3] module: Ignore delete_id parameter

On Wed, Sep 27, 2017 at 1:40 PM, Jon Derrick <jonathan.derrick@...el.com> wrote:
> The PCI driver delete_id parameter is handled in each individual driver
> registration callback.
>
> Signed-off-by: Jon Derrick <jonathan.derrick@...el.com>
> ---
>  kernel/module.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/kernel/module.c b/kernel/module.c
> index de66ec8..2b2dccf 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -3620,6 +3620,13 @@ static int unknown_module_param_cb(char *param, char *val, const char *modname,
>                 return 0;
>         }
>
> +       /*
> +        * Ignore driver delete list arguments. They are handled by driver
> +        * registration callbacks
> +        */
> +       if (strcmp(param, "delete_id") == 0)
> +               return 0;
> +

Does this preclude something like:

    modprobe ahci delete_id=1234:5678?