linux-kernel - Re: [PATCHv7 10/19] x86/mm: Make __PHYSICAL_MASK_SHIFT and __VIRTUAL_MASK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170928082813.lvr45p53niznhycx@gmail.com>
Date:   Thu, 28 Sep 2017 10:28:13 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>, x86@...nel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Andy Lutomirski <luto@...capital.net>,
        Cyrill Gorcunov <gorcunov@...nvz.org>,
        Borislav Petkov <bp@...e.de>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCHv7 10/19] x86/mm: Make __PHYSICAL_MASK_SHIFT and
 __VIRTUAL_MASK_SHIFT dynamic


* Kirill A. Shutemov <kirill.shutemov@...ux.intel.com> wrote:

> --- a/arch/x86/mm/dump_pagetables.c
> +++ b/arch/x86/mm/dump_pagetables.c
> @@ -82,8 +82,8 @@ static struct addr_marker address_markers[] = {
>  	{ 0/* VMALLOC_START */, "vmalloc() Area" },
>  	{ 0/* VMEMMAP_START */, "Vmemmap" },
>  #ifdef CONFIG_KASAN
> -	{ KASAN_SHADOW_START,	"KASAN shadow" },
> -	{ KASAN_SHADOW_END,	"KASAN shadow end" },
> +	{ 0/* KASAN_SHADOW_START */,	"KASAN shadow" },
> +	{ 0/* KASAN_SHADOW_END */,	"KASAN shadow end" },

What's this? Looks hacky.

Thanks,

	Ingo