linux-kernel - [PATCH] Don't set wildcard filter for non-existing module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b13012c-8b08-8eb4-2cbd-0abdd1699af6@siemens.com>
Date:   Thu, 28 Sep 2017 13:11:40 +0200
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     Steven Rostedt <rostedt@...dmis.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: [PATCH] Don't set wildcard filter for non-existing module

From: Jan Kiszka <jan.kiszka@...mens.com>

If filter_mod is NULL, there is no need to add it to the list. This
avoids premature termination of trace-cmd on systems without
CONFIG_DYNAMIC_FTRACE.

Signed-off-by: Jan Kiszka <jan.kiszka@...mens.com>
---
 trace-record.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/trace-record.c b/trace-record.c
index 020a373..a0b6541 100644
--- a/trace-record.c
+++ b/trace-record.c
@@ -4680,7 +4680,7 @@ void trace_record (int argc, char **argv)
 		}
 	}
 
-	if (!filtered)
+	if (!filtered && instance->filter_mod)
 		add_func(&instance->filter_funcs,
 			 instance->filter_mod, "*");
 
-- 
2.12.3