linux-kernel - Re: [PATCH] irq/generic-chip: Fix memory leak of domain->name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59CC7C35.1040409@rock-chips.com>
Date:   Thu, 28 Sep 2017 12:36:05 +0800
From:   jeffy <jeffy.chen@...k-chips.com>
To:     Thomas Gleixner <tglx@...utronix.de>
CC:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irq/generic-chip: Fix memory leak of domain->name

Hi Thomas,

On 09/28/2017 11:18 AM, jeffy wrote:
>>
>> I don't think that this is the proper thing to do. There is no reason why
>> the domain should have the same name as the irq chip. So we rather should
>> do:
>>
>>     if (!d->name)
>>         d->name = name;
>>
>> Along with a proper comment.
> that is better, will do it in next version :)

it looks like the __irq_domain_add() would guarantee every domain has a 
valid name, maybe we can just remove this?