lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 29 Sep 2017 10:51:12 +0200
From:   Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:     Gregory CLEMENT <gregory.clement@...e-electrons.com>
Cc:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Yehuda Yitschak <yehuday@...vell.com>,
        Omri Itach <omrii@...vell.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Richard Weinberger <richard@....at>,
        Antoine Tenart <antoine.tenart@...e-electrons.com>,
        Miquèl Raynal 
        <miquel.raynal@...e-electrons.com>, linux-kernel@...r.kernel.org,
        Nadav Haklai <nadavh@...vell.com>,
        Marek Vasut <marek.vasut@...il.com>,
        linux-mtd@...ts.infradead.org,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        Shadi Ammouri <shadi@...vell.com>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Hanna Hawa <hannah@...vell.com>,
        Igal Liberman <igall@...vell.com>
Subject: Re: [PATCH] mtd: nand: pxa3xx_nand: Update Kconfig information

Hello,

Entering nitpick mode.

On Thu, 28 Sep 2017 16:36:57 +0200, Gregory CLEMENT wrote:

>  	  This enables the driver for the NAND flash device found on
> -	  PXA3xx processors (NFCv1) and also on Armada 370/XP (NFCv2).
> +	  PXA3xx processors (NFCv1) and also on Armada 32bits(XP, 370, 375,

missing space before parenthesis.

> +	  38x, 39x) and 64bits (7K, 8K) (NFCv2).

Also "Armada 32bits" isn't very good IMO, what about:

	and also on 32-bit Armada platforms (XP, 370, 375, 38x, 39x)
	and 64-bit Armada platforms (7K, 8K) (NFCv2).

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ