linux-kernel - Re: [PATCH] mtd: nand: pxa3xx_nand: Update Kconfig information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87k20hhoo2.fsf@free-electrons.com>
Date:   Fri, 29 Sep 2017 10:52:45 +0200
From:   Gregory CLEMENT <gregory.clement@...e-electrons.com>
To:     Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
Cc:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Yehuda Yitschak <yehuday@...vell.com>,
        Omri Itach <omrii@...vell.com>,
        Marcin Wojtas <mw@...ihalf.com>,
        Richard Weinberger <richard@....at>,
        Antoine Tenart <antoine.tenart@...e-electrons.com>,
        Miquèl Raynal <miquel.raynal@...e-electrons.com>,
        linux-kernel@...r.kernel.org, Nadav Haklai <nadavh@...vell.com>,
        Marek Vasut <marek.vasut@...il.com>,
        linux-mtd@...ts.infradead.org,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        Shadi Ammouri <shadi@...vell.com>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Hanna Hawa <hannah@...vell.com>,
        Igal Liberman <igall@...vell.com>
Subject: Re: [PATCH] mtd: nand: pxa3xx_nand: Update Kconfig information

Hi Thomas,
 
 On ven., sept. 29 2017, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com> wrote:

> Hello,
>
> Entering nitpick mode.

nitpick accpeted! :)

I am going to send a v2.

Gregory

>
> On Thu, 28 Sep 2017 16:36:57 +0200, Gregory CLEMENT wrote:
>
>>  	  This enables the driver for the NAND flash device found on
>> -	  PXA3xx processors (NFCv1) and also on Armada 370/XP (NFCv2).
>> +	  PXA3xx processors (NFCv1) and also on Armada 32bits(XP, 370, 375,
>
> missing space before parenthesis.
>
>> +	  38x, 39x) and 64bits (7K, 8K) (NFCv2).
>
> Also "Armada 32bits" isn't very good IMO, what about:
>
> 	and also on 32-bit Armada platforms (XP, 370, 375, 38x, 39x)
> 	and 64-bit Armada platforms (7K, 8K) (NFCv2).
>
> Best regards,
>
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com