linux-kernel - Re: [PATCH] mm, hugetlb: fix "treat_as_movable" condition in htlb_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e085bc8c-6614-5c9b-6702-5ed477bc856c@oracle.com>
Date:   Fri, 29 Sep 2017 14:16:10 -0700
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Alexandru Moise <00moses.alexander00@...il.com>,
        akpm@...ux-foundation.org,
        Anshuman Khandual <khandual@...ux.vnet.ibm.com>
Cc:     mhocko@...e.com, n-horiguchi@...jp.nec.com,
        aneesh.kumar@...ux.vnet.ibm.com, punit.agrawal@....com,
        gerald.schaefer@...ibm.com, aarcange@...hat.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        kirill@...temov.name
Subject: Re: [PATCH] mm, hugetlb: fix "treat_as_movable" condition in
 htlb_alloc_mask

Adding Anshuman

On 09/29/2017 01:43 PM, Alexandru Moise wrote:
> On Fri, Sep 29, 2017 at 05:13:39PM +0200, Alexandru Moise wrote:
>>
>> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
>> index 424b0ef08a60..ab28de0122af 100644
>> --- a/mm/hugetlb.c
>> +++ b/mm/hugetlb.c
>> @@ -926,7 +926,7 @@ static struct page *dequeue_huge_page_nodemask(struct hstate *h, gfp_t gfp_mask,
>>  /* Movability of hugepages depends on migration support. */
>>  static inline gfp_t htlb_alloc_mask(struct hstate *h)
>>  {
>> -	if (hugepages_treat_as_movable || hugepage_migration_supported(h))
>> +	if (hugepages_treat_as_movable && hugepage_migration_supported(h))
>>  		return GFP_HIGHUSER_MOVABLE;
>>  	else
>>  		return GFP_HIGHUSER;
>> -- 
>> 2.14.2
>>
> 
> I seem to have terribly misunderstood the semantics of this flag wrt hugepages,
> please ignore this for now.

That is Okay, it made me look at this code more closely.

static inline bool hugepage_migration_supported(struct hstate *h)
{
#ifdef CONFIG_ARCH_ENABLE_HUGEPAGE_MIGRATION
        if ((huge_page_shift(h) == PMD_SHIFT) ||
                (huge_page_shift(h) == PGDIR_SHIFT))
                return true;
        else
                return false;
#else
        return false;
#endif
}

So, hugepage_migration_supported() can only return true if
ARCH_ENABLE_HUGEPAGE_MIGRATION is defined.  Commit c177c81e09e5
restricts hugepage_migration_support to x86_64.  So,
ARCH_ENABLE_HUGEPAGE_MIGRATION is only defined for x86_64.

Commit 94310cbcaa3c added the ability to migrate gigantic hugetlb pages
at the PGD level.  This added the check for PGD level pages to
hugepage_migration_supported(), which is only there if
ARCH_ENABLE_HUGEPAGE_MIGRATION is defined.  IIUC, this functionality
was added for powerpc.  Yet, powerpc does not define
ARCH_ENABLE_HUGEPAGE_MIGRATION (unless I am missing something).

-- 
Mike Kravetz