lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Sep 2017 09:09:40 +0200 From: Vlastimil Babka <vbabka@...e.cz> To: Andrew Morton <akpm@...ux-foundation.org>, Kemi Wang <kemi.wang@...el.com> Cc: "Luis R . Rodriguez" <mcgrof@...nel.org>, Kees Cook <keescook@...omium.org>, Jonathan Corbet <corbet@....net>, Michal Hocko <mhocko@...e.com>, Mel Gorman <mgorman@...hsingularity.net>, Johannes Weiner <hannes@...xchg.org>, Christopher Lameter <cl@...ux.com>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Dave <dave.hansen@...ux.intel.com>, Tim Chen <tim.c.chen@...el.com>, Andi Kleen <andi.kleen@...el.com>, Jesper Dangaard Brouer <brouer@...hat.com>, Ying Huang <ying.huang@...el.com>, Aaron Lu <aaron.lu@...el.com>, Proc sysctl <linux-fsdevel@...r.kernel.org>, Linux MM <linux-mm@...ck.org>, Linux Kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v3] mm, sysctl: make NUMA stats configurable On 09/28/2017 11:29 PM, Andrew Morton wrote: > On Thu, 28 Sep 2017 14:11:41 +0800 Kemi Wang <kemi.wang@...el.com> wrote: > >> This is the second step which introduces a tunable interface that allow >> numa stats configurable for optimizing zone_statistics(), as suggested by >> Dave Hansen and Ying Huang. > > Looks OK I guess. > > I fiddled with it a lot. Please consider: > > From: Andrew Morton <akpm@...ux-foundation.org> > Subject: mm-sysctl-make-numa-stats-configurable-fix > > - tweak documentation > > - move advisory message from start_kernel() into mm_init() (I'm not sure > we really need this message) Actually, I'm not sure we need any of the current messages, or to have them at higher priority than pr_debug()? They are all triggered by admin action, or unconditionally upon boot. OTOH I think that an useful message that's currently missing would be when the static_key_enable() is triggered in auto mode. Bonus points for including the name of the process and the stat file that was read. However static_key_enable() returns void and not whether it actually flipped the switch, so it's not trivial.
Powered by blists - more mailing lists