linux-kernel - Re: [PATCH] HID: hid-multitouch: forward MSC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171002130152.GI1063@mail.corp.redhat.com>
Date:   Mon, 2 Oct 2017 15:01:52 +0200
From:   Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:     Jiri Kosina <jikos@...nel.org>
Cc:     Nicolas Boichat <drinkcat@...omium.org>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        dtor@...omium.org
Subject: Re: [PATCH] HID: hid-multitouch: forward MSC_TIMESTAMP

On Oct 02 2017 or thereabouts, Jiri Kosina wrote:
> On Tue, 22 Aug 2017, Nicolas Boichat wrote:
> 
> > Computes and forwards the device timestamp according to the
> > specification.
> > 
> > Many devices use a 16-bit timestamp field, with a resolution
> > of 100us, therefore rolling around very frequently (every
> > 6.5 seconds). To make sure there is no ambiguity, the
> > timestamp reported to the input stack reset to 0 whenever
> > the time between 2 received events is greater than
> > MAX_TIMESTAMP_INTERVAL (1 second).
> > 
> > Signed-off-by: Nicolas Boichat <drinkcat@...omium.org>
> 
> > ---
> > 
> > Inspired from Benjamin Tissoires's patch here:
> > https://patchwork.kernel.org/patch/1742181/, and changing the
> > logic to resynchronize the timestamps to use received time
> > instead of a potentially more fragile difference between
> > the 2 deltas.
> 
> Benjamin, any objections on merging this one for 4.15? I like it.
> 

No objections from my side.

Acked-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

Cheers,
Benjamin

> Thanks,
> 
> -- 
> Jiri Kosina
> SUSE Labs
>