linux-kernel - RE: [PATCH] mm/hmm: constify hmm_devmem_page_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5de6865d177849a389f02e064b2ff65b@HQMAIL105.nvidia.com>
Date:   Mon, 2 Oct 2017 21:54:43 +0000
From:   Ralph Campbell <rcampbell@...dia.com>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        Jérôme Glisse <jglisse@...hat.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: RE: [PATCH] mm/hmm: constify hmm_devmem_page_get_drvdata() parameter

The use case is when called by struct hmm_devmem_ops.fault() which passes a const struct page * pointer and hmm_devmem_page_get_drvdata() is called to get the private data.
Since HMM was only recently added, it only affects kernels after September 8, 2017.

> -----Original Message-----
> From: Andrew Morton [mailto:akpm@...ux-foundation.org]
> Sent: Monday, October 2, 2017 2:41 PM
> To: Jérôme Glisse <jglisse@...hat.com>
> Cc: linux-kernel@...r.kernel.org; linux-mm@...ck.org; Ralph Campbell
> <rcampbell@...dia.com>
> Subject: Re: [PATCH] mm/hmm: constify hmm_devmem_page_get_drvdata()
> parameter
> 
> On Mon,  2 Oct 2017 15:32:54 -0400 Jérôme Glisse <jglisse@...hat.com>
> wrote:
> 
> > From: Ralph Campbell <rcampbell@...dia.com>
> >
> > Constify pointer parameter to avoid issue when use from code that only
> > has const struct page pointer to use in the first place.
> 
> That's rather vague.  Does such calling code exist in the kernel?  This affects the
> which-kernel-gets-patched decision.