linux-kernel - Re: [PATCH 1/3] scsi: ufs: Change HCI marco to actual bit position

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 3 Oct 2017 13:58:19 +0530
From:   Alim Akhtar <alim.akhtar@...sung.com>
To:     Bart Van Assche <Bart.VanAssche@....com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     "subhashj@...eaurora.org" <subhashj@...eaurora.org>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "vinholikatti@...il.com" <vinholikatti@...il.com>
Subject: Re: [PATCH 1/3] scsi: ufs: Change HCI marco to actual bit position

Hi Bart,

On 10/02/2017 10:11 PM, Bart Van Assche wrote:
> On Sat, 2017-09-30 at 11:52 +0530, Alim Akhtar wrote:
>> Currently UFS HCI uses UFS_BIT() macro to get various bit
>> position for the hardware registers status bits. Which makes
>> code longer instead of shorter. This macro does not improve
>> code readability as well.
>> Lets re-write these macro definition with the actual bit position.
> 
> Can the three patches in this series be combined into a single patch?
> 
Since UFS_BIT() used in qcom-ufs driver as well, so I thought of keeping 
them in separate patches. This way "git bisect" will work all the time.

>> -#define UFS_BIT(x)	(1L << (x))
>> [ ... ]
>> +#define UFS_BIT(x)     (1L << (x))
> 
> If you want to keep the three patches separate, please make sure that this
> patch does not modify the UFS_BIT() definition. Please also fix the spelling
> of the title of this patch (marco -> macro).
> 
Ok, will fix these
> Thanks,
> 
> Bart.
>