linux-kernel - Re: [PATCH 1/2] writeback: eliminate work item allocation in bd_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171004072635.GP11879@quack2.suse.cz>
Date:   Wed, 4 Oct 2017 09:26:35 +0200
From:   Jan Kara <jack@...e.cz>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        hannes@...xchg.org, jack@...e.cz
Subject: Re: [PATCH 1/2] writeback: eliminate work item allocation in
 bd_start_writeback()

On Tue 03-10-17 09:16:20, Jens Axboe wrote:
> Handle start-all writeback like we do periodic or kupdate
> style writeback - by marking the bdi_writeback as needing a full
> flush, and simply waking the thread. This eliminates the need to
> allocate and queue a specific work item just for this purpose.
> 
> After this change, we truly only ever have one of them running at
> any point in time. We mark the need to start all flushes, and the
> writeback thread will clear it once it has processed the request.
> 
> Signed-off-by: Jens Axboe <axboe@...nel.dk>

Just one nit below. You can add:

Reviewed-by: Jan Kara <jack@...e.cz>

> diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h
> index 420de5c7c7f9..f0f1df29d6b8 100644
> --- a/include/linux/backing-dev-defs.h
> +++ b/include/linux/backing-dev-defs.h
> @@ -116,6 +116,7 @@ struct bdi_writeback {
>  
>  	struct fprop_local_percpu completions;
>  	int dirty_exceeded;
> +	int start_all_reason;

This should be 'enum wb_reason' instead of 'int'.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR