linux-kernel - Re: [PATCH 1/2] writeback: eliminate work item allocation in bd_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a139134d-0e65-fac4-1c77-22fb729cadf6@kernel.dk>
Date:   Wed, 4 Oct 2017 08:42:12 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Jan Kara <jack@...e.cz>
Cc:     linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        hannes@...xchg.org
Subject: Re: [PATCH 1/2] writeback: eliminate work item allocation in
 bd_start_writeback()

On 10/04/2017 01:26 AM, Jan Kara wrote:
>> diff --git a/include/linux/backing-dev-defs.h b/include/linux/backing-dev-defs.h
>> index 420de5c7c7f9..f0f1df29d6b8 100644
>> --- a/include/linux/backing-dev-defs.h
>> +++ b/include/linux/backing-dev-defs.h
>> @@ -116,6 +116,7 @@ struct bdi_writeback {
>>  
>>  	struct fprop_local_percpu completions;
>>  	int dirty_exceeded;
>> +	int start_all_reason;
> 
> This should be 'enum wb_reason' instead of 'int'.

Yes good point, I'll move the enum and change 'start_all_reason' to be
of type enum wb_reason.

Thanks for the review!

-- 
Jens Axboe