linux-kernel - Re: [PATCH] mmc: dw_mmc-k3: make array hs_timing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 4 Oct 2017 10:59:50 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Jaehoon Chung <jh80.chung@...sung.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: dw_mmc-k3: make array hs_timing_cfg static

On 3 October 2017 at 11:56, Colin King <colin.king@...onical.com> wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The array hs_timing_cfg is local to the source and does not need to
> be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'hs_timing_cfg' was not declared. Should it be static?
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/dw_mmc-k3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
> index 64cda84b2302..73fd75c3c824 100644
> --- a/drivers/mmc/host/dw_mmc-k3.c
> +++ b/drivers/mmc/host/dw_mmc-k3.c
> @@ -75,7 +75,7 @@ struct hs_timing {
>         u32 smpl_phase_min;
>  };
>
> -struct hs_timing hs_timing_cfg[TIMING_MODE][TIMING_CFG_NUM] = {
> +static struct hs_timing hs_timing_cfg[TIMING_MODE][TIMING_CFG_NUM] = {
>         { /* reserved */ },
>         { /* SD */
>                 {7, 0, 15, 15,},  /* 0: LEGACY 400k */
> --
> 2.14.1
>