linux-kernel - Re: [Outreachy kernel] [PATCH 3/3] evaluate: make pointers in string arrays constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171004142910.GA22122@salvia>
Date:   Wed, 4 Oct 2017 16:29:10 +0200
From:   Pablo Neira Ayuso <pablo@...filter.org>
To:     Harsha Sharma <harshasharmaiitr@...il.com>
Cc:     netfilter-devel@...r.kernel.org, linux-kernel@...r.kernel.org,
        outreachy-kernel@...glegroups.com
Subject: Re: [Outreachy kernel] [PATCH 3/3] evaluate: make pointers in string
 arrays constant

On Mon, Oct 02, 2017 at 01:02:50PM +0530, Harsha Sharma wrote:
> static const char * array should probably be static const char * const
> array
> as per linux-kernel coding style
> 
> Signed-off-by: Harsha Sharma <harshasharmaiitr@...il.com>
> ---
>  src/evaluate.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/evaluate.c b/src/evaluate.c
> index b783054..f48801a 100644
> --- a/src/evaluate.c
> +++ b/src/evaluate.c
> @@ -33,7 +33,7 @@
>  static struct output_ctx octx_debug_dummy;
>  static int expr_evaluate(struct eval_ctx *ctx, struct expr **expr);
>  
> -static const char *byteorder_names[] = {
> +static const char * const byteorder_names[] = {

I can see more string array that could use this in the nftables tree.
Please, fix all in one single patch.

Thanks.