linux-kernel - Re: [PATCH] PM / OPP: Add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3dd282e-220d-5a10-7a0e-10c1acaee737@codeaurora.org>
Date:   Wed, 4 Oct 2017 09:42:05 -0700
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>,
        Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>
Cc:     linux-pm@...r.kernel.org,
        Tobias Jordan <Tobias.Jordan@...ktrobit.com>,
        "4 . 3+" <stable@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PM / OPP: Add missing of_node_put(np)

On 10/03/2017 11:05 PM, Viresh Kumar wrote:
> From: Tobias Jordan <Tobias.Jordan@...ktrobit.com>
>
> The for_each_available_child_of_node() loop in _of_add_opp_table_v2()
> doesn't drop the reference to "np" on errors. Fix that.
>
> Fixes: 274659029c9d ("PM / OPP: Add support to parse "operating-points-v2" bindings")
> Cc: 4.3+ <stable@...r.kernel.org> # 4.3+
> Signed-off-by: Tobias Jordan <Tobias.Jordan@...ktrobit.com>
> [ VK: Improved commit log. ]
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>

Looks like that opp_table->np = opp_np assignment in this function needs
to do an of_node_get() because the caller of this function puts the
pointer unconditionally.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project