linux-kernel - Re: [PATCH] nfp: convert nfp_eth_set_bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171004.104430.371058999122748879.davem@davemloft.net>
Date:   Wed, 04 Oct 2017 10:44:30 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mka@...omium.org
Cc:     jakub.kicinski@...ronome.com, simon.horman@...ronome.com,
        dirk.vandermerwe@...ronome.com, oss-drivers@...ronome.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        renato.golin@...aro.org, manojgupta@...omium.org,
        groeck@...omium.org, dianders@...omium.org
Subject: Re: [PATCH] nfp: convert nfp_eth_set_bit_config() into a macro

From: Matthias Kaehlcke <mka@...omium.org>
Date: Wed, 4 Oct 2017 10:42:15 -0700

> Given that this doesn't seem to be a widespread issue in the kernel
> personally I would consider the conversion to a macro in this case an
> acceptable solution, though it is definitely ugly. However I'm not the
> owner of the driver or the subsystem, so my opinion doesn't really
> carry much weight here ;-)

Losing type checking is a serious regression as far as I am concerned.