linux-kernel - Re: [PATCH 1/2] selinux: fix build warning by removing the unused sid variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1507148778.1491.10.camel@tycho.nsa.gov>
Date:   Wed, 04 Oct 2017 16:26:18 -0400
From:   Stephen Smalley <sds@...ho.nsa.gov>
To:     Corentin Labbe <clabbe.montjoie@...il.com>, paul@...l-moore.com,
        eparis@...isplace.org, james.l.morris@...cle.com, serge@...lyn.com
Cc:     linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, selinux@...ho.nsa.gov
Subject: Re: [PATCH 1/2] selinux: fix build warning by removing the unused
 sid variable

On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote:
> This patch remove the unused variable sid
> This fix the following build warning:
> security/selinux/hooks.c:2921:6: warning: variable 'sid' set but not
> used [-Wunused-but-set-variable]
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>

Acked-by: Stephen Smalley <sds@...ho.nsa.gov>

> ---
>  security/selinux/hooks.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index f5d304736852..8507a56f85e4 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -2918,13 +2918,12 @@ static int selinux_inode_init_security(struct
> inode *inode, struct inode *dir,
>  {
>  	const struct task_security_struct *tsec =
> current_security();
>  	struct superblock_security_struct *sbsec;
> -	u32 sid, newsid, clen;
> +	u32 newsid, clen;
>  	int rc;
>  	char *context;
>  
>  	sbsec = dir->i_sb->s_security;
>  
> -	sid = tsec->sid;
>  	newsid = tsec->create_sid;
>  
>  	rc = selinux_determine_inode_label(current_security(),