linux-kernel - Re: [PATCH 2/2] selinux: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1507148872.1491.11.camel@tycho.nsa.gov>
Date:   Wed, 04 Oct 2017 16:27:52 -0400
From:   Stephen Smalley <sds@...ho.nsa.gov>
To:     Corentin Labbe <clabbe.montjoie@...il.com>, paul@...l-moore.com,
        eparis@...isplace.org, james.l.morris@...cle.com, serge@...lyn.com
Cc:     linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, selinux@...ho.nsa.gov
Subject: Re: [PATCH 2/2] selinux: fix build warning

On Wed, 2017-10-04 at 20:32 +0200, Corentin Labbe wrote:
> This patch make selinux_task_prlimit() static since it is not used
> anywhere else.
> This fix the following build warning:
> security/selinux/hooks.c:3981:5: warning: no previous prototype for
> 'selinux_task_prlimit' [-Wmissing-prototypes]
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>

Acked-by: Stephen Smalley <sds@...ho.nsa.gov>

> ---
>  security/selinux/hooks.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
> index 8507a56f85e4..b8a022f4b4a7 100644
> --- a/security/selinux/hooks.c
> +++ b/security/selinux/hooks.c
> @@ -3977,8 +3977,8 @@ static int selinux_task_getioprio(struct
> task_struct *p)
>  			    PROCESS__GETSCHED, NULL);
>  }
>  
> -int selinux_task_prlimit(const struct cred *cred, const struct cred
> *tcred,
> -			 unsigned int flags)
> +static int selinux_task_prlimit(const struct cred *cred, const
> struct cred *tcred,
> +				unsigned int flags)
>  {
>  	u32 av = 0;
>