linux-kernel - Re: [PATCH 12/20] ARM: dts: sun4i: Remove underscores from nodes names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v6472+oknoc0uXf+Z_Onm-AEFiN7HenjdetK-s2QJ3TZ3Q@mail.gmail.com>
Date:   Thu, 5 Oct 2017 23:49:47 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:     Chen-Yu Tsai <wens@...e.org>, Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 12/20] ARM: dts: sun4i: Remove underscores from nodes names

On Thu, Oct 5, 2017 at 6:49 PM, Maxime Ripard
<maxime.ripard@...e-electrons.com> wrote:
> Some GPIO pinctrl nodes cannot be easily removed, because they would also
> change the pin configuration, for example to add a pull resistor or change
> the current delivered by the pin.
>
> Those nodes still have underscores and unit-addresses in their node names
> in our DTs, so adjust their name to remove the warnings.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> ---

[...]

> diff --git a/arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts b/arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts
> index 46e485ff925b..5081303f79e7 100644
> --- a/arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts
> +++ b/arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts
> @@ -101,7 +101,7 @@
>  &i2c2 {
>         status = "okay";
>
> -       pixcir_ts@5c {
> +       touchscreen@5c {

You also fixed up a name here. Please mention it.

>                 compatible = "pixcir,pixcir_tangoc";
>                 reg = <0x5c>;
>                 interrupt-parent = <&pio>;

[...]

Otherwise,

Acked-by: Chen-Yu Tsai <wens@...e.org>