linux-kernel - Re: [PATCH 13/20] ARM: dts: sun4i: Remove gpio-keys warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v64df+tQnM1W=KDWNXsnRhEVo2hsTB1YJsPJkzvgw8J1ig@mail.gmail.com>
Date:   Thu, 5 Oct 2017 23:51:02 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Maxime Ripard <maxime.ripard@...e-electrons.com>
Cc:     Chen-Yu Tsai <wens@...e.org>, Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 13/20] ARM: dts: sun4i: Remove gpio-keys warnings

On Thu, Oct 5, 2017 at 6:49 PM, Maxime Ripard
<maxime.ripard@...e-electrons.com> wrote:
> Some gpio-keys definitions in our DTs were having buttons defined with a
> unit-address and that would generate a DTC warning.
>
> Change the buttons node names to remove the warnings.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> ---
>  arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts | 40 ++++++++++-----------
>  arch/arm/boot/dts/sun4i-a10-pcduino.dts      |  6 +--
>  2 files changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts b/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts
> index 7c7f12132ea3..13224f5ac166 100644
> --- a/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts
> +++ b/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts
> @@ -67,7 +67,7 @@
>                 #size-cells = <0>;
>                 poll-interval = <20>;
>
> -               button@0 {
> +               left-joystick-left {

Does this fit the naming scheme? Should we have "-button" suffices?

Otherwise,

Acked-by: Chen-Yu Tsai <wens@...e.org>