linux-kernel - Re: [PATCH] s390: qdio: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jL+za1du_1kOZj1i50kXDGzY91EvLhnO5EJSQ1q1WN6NQ@mail.gmail.com>
Date:   Thu, 5 Oct 2017 09:58:55 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Sebastian Ott <sebott@...ux.vnet.ibm.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Peter Oberparleiter <oberpar@...ux.vnet.ibm.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        "linux-s390@...r.kernel.org" <linux-s390@...r.kernel.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] s390: qdio: Convert timers to use timer_setup()

On Thu, Oct 5, 2017 at 2:13 AM, Sebastian Ott <sebott@...ux.vnet.ibm.com> wrote:
> On Wed, 4 Oct 2017, Kees Cook wrote:
>> In preparation for unconditionally passing the struct timer_list pointer to
>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> to pass the timer pointer explicitly.
>
>> -void qdio_outbound_timer(unsigned long data)
>> +void qdio_outbound_timer(struct timer_list *t)
>>  {
>> -     struct qdio_q *q = (struct qdio_q *)data;
>> +     struct qdio_q *q = from_timer(q, t, o.out.timer);
>                                             ^
>                              this should be u.out.timer

Oh thank you, good catch!

> Will be applied to s390/linux.git

Did you fix this up already or should I send a v2?

-Kees

-- 
Kees Cook
Pixel Security