linux-kernel - RE: [PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Oct 2017 17:04:26 +0000
From:   <Mario.Limonciello@...l.com>
To:     <andy.shevchenko@...il.com>
CC:     <dvhart@...radead.org>, <linux-kernel@...r.kernel.org>,
        <platform-driver-x86@...r.kernel.org>, <luto@...nel.org>,
        <quasisec@...gle.com>, <pali.rohar@...il.com>, <rjw@...ysocki.net>,
        <mjg59@...gle.com>, <hch@....de>, <greg@...ah.com>
Subject: RE: [PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI
 descriptor into it's own driver

> -----Original Message-----
> From: Andy Shevchenko [mailto:andy.shevchenko@...il.com]
> Sent: Thursday, October 5, 2017 12:34 AM
> To: Limonciello, Mario <Mario_Limonciello@...l.com>
> Cc: dvhart@...radead.org; LKML <linux-kernel@...r.kernel.org>; Platform Driver
> <platform-driver-x86@...r.kernel.org>; Andy Lutomirski <luto@...nel.org>;
> quasisec@...gle.com; Pali Rohár <pali.rohar@...il.com>; Rafael J. Wysocki
> <rjw@...ysocki.net>; mjg59@...gle.com; Christoph Hellwig <hch@....de>;
> Greg KH <greg@...ah.com>
> Subject: Re: [PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI
> descriptor into it's own driver
> 
> On Thu, Oct 5, 2017 at 1:48 AM, Mario Limonciello
> <mario.limonciello@...l.com> wrote:
> > All communication on individual GUIDs should occur in separate drivers.
> > Allowing a driver to communicate with the bus to another GUID is just
> > a hack that discourages drivers to adopt the bus model.
> >
> > The information found from the WMI descriptor driver is now exported
> > for use by other drivers.
> 
> > +       priv = list_first_entry_or_null(&wmi_list,
> > +                                       struct descriptor_priv,
> > +                                       list);
> 
> > +       priv = list_first_entry_or_null(&wmi_list,
> > +                                       struct descriptor_priv,
> > +                                       list);
> 
> static inline ...to_priv(...)
> {
>  return list_first_entry_...();
> }
> 
> > +       list_add_tail(&priv->list, &wmi_list);
> 
> > +       list_del(&priv->list);
> 
> Do these need locking?

Yeah this seems like a good idea.  I'll add it in.

> 
> > +bool dell_wmi_get_interface_version(u32 *version);
> > +bool dell_wmi_get_size(u32 *size);
> 
> This might need stubs when module is not selected (when functionality
> is optional if it would be the case), otherwise all users should
> select it explicitly.

Per Darren's other threads I'm adjusting Kconfig to make sure this module
is selected.  It's realistically not optional when using these others.