linux-kernel - Re: [PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171005172210.GC31452@fury>
Date:   Thu, 5 Oct 2017 10:22:10 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Mario.Limonciello@...l.com
Cc:     andy.shevchenko@...il.com, linux-kernel@...r.kernel.org,
        platform-driver-x86@...r.kernel.org, luto@...nel.org,
        quasisec@...gle.com, pali.rohar@...il.com, rjw@...ysocki.net,
        mjg59@...gle.com, hch@....de, greg@...ah.com
Subject: Re: [PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI
 descriptor into it's own driver

On Thu, Oct 05, 2017 at 02:47:15PM +0000, Mario.Limonciello@...l.com wrote:
> > >
> > > So I believe it should be a mandatory runtime dependency due to needing
> > > the symbol dell_wmi_get_interface_version.  Depmod should be handling
> > > this then no?
> > 
> > This was nagging me all night, and I was thinking the last time I had to
> > use this it was indeed a runtime dependency. Sorry for the noise on
> > this.
> > 
> > The kconfig needs to be setup such that dell-wmi-descriptor cannot be a
> > module if the dependent drivers are modules.
> > 
> > --
> > Darren Hart
> > VMware Open Source Technology Center
> 
> Even if the others are modules shouldn't module ordering from depmod still DTRT?
> You still won't be able to load dell-wmi.ko until dell-wmi-descriptor.ko was loaded.
> 

I worded that wrong *facepalm*, let me try again...

The kconfig needs to be setup such that dell-wmi-descriptor cannot be a
module if the dependent drivers are built-in.

-- 
Darren Hart
VMware Open Source Technology Center