linux-kernel - Re: [PATCH] drm/i915: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jLGTcHfUMY=fwZN5-dx-gXzypiU58hRXJDJVDaj-Y5v5w@mail.gmail.com>
Date:   Thu, 5 Oct 2017 10:35:37 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        David Airlie <airlied@...ux.ie>,
        Chris Wilson <chris@...is-wilson.co.uk>,
        Tvrtko Ursulin <tvrtko.ursulin@...el.com>,
        Oscar Mateo <oscar.mateo@...el.com>,
        intel-gfx@...ts.freedesktop.org,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] drm/i915: Convert timers to use timer_setup()

On Thu, Oct 5, 2017 at 6:45 AM, Joonas Lahtinen
<joonas.lahtinen@...ux.intel.com> wrote:
> On Wed, 2017-10-04 at 17:54 -0700, Kees Cook wrote:
>> In preparation for unconditionally passing the struct timer_list pointer to
>> all timer callbacks, switch to using the new timer_setup() and from_timer()
>> to pass the timer pointer explicitly.
>>
>> Cc: Daniel Vetter <daniel.vetter@...el.com>
>> Cc: Jani Nikula <jani.nikula@...ux.intel.com>
>> Cc: David Airlie <airlied@...ux.ie>
>> Cc: Chris Wilson <chris@...is-wilson.co.uk>
>> Cc: Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@...el.com>
>> Cc: Oscar Mateo <oscar.mateo@...el.com>
>> Cc: intel-gfx@...ts.freedesktop.org
>> Cc: dri-devel@...ts.freedesktop.org
>> Cc: Thomas Gleixner <tglx@...utronix.de>
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>
> <SNIP>
>
>> @@ -32,9 +32,9 @@ static struct mock_request *first_request(struct mock_engine *engine)
>>                                       link);
>>  }
>>
>> -static void hw_delay_complete(unsigned long data)
>> +static void hw_delay_complete(struct timer_list *t)
>>  {
>> -     struct mock_engine *engine = (typeof(engine))data;
>> +     struct mock_engine *engine = from_timer(engine, t, hw_delay);
>
> The order is bit strange to me, it's not same as with container_of, but
> I guess GCC will complain for getting it wrong. It's also slightly
> different doing the typeof for you, so I guess it makes sense, so:

Yeah, this seemed to be the least bad of several options. Other things
ended up being either very long, named unlike anything else already in
the kernel, etc.

> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>

Thanks!

> Do you expect for us to merge or are you looking to merge all timer
> changes from single tree?

If you have -rc3 in your tree already, please take this into your
tree. If you prefer the timer tree to carry it, that can happen too.
tglx suggested to me that it was better for maintainers to carry the
changes.

-Kees

-- 
Kees Cook
Pixel Security