linux-kernel - RE: [PATCH 0/3] Arm: dts: stm32: remove extra compatible uart string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Oct 2017 17:36:26 +0000
From:   Vikas MANOCHA <vikas.manocha@...com>
To:     Alexandre TORGUE <alexandre.torgue@...com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Patrice CHOTARD <patrice.chotard@...com>
Subject: RE: [PATCH 0/3] Arm: dts: stm32: remove extra compatible uart string

Hi Alex,

> -----Original Message-----
> From: Alexandre TORGUE
> Sent: Thursday, October 05, 2017 9:02 AM
> To: Vikas MANOCHA <vikas.manocha@...com>; linux-kernel@...r.kernel.org
> Cc: Patrice CHOTARD <patrice.chotard@...com>
> Subject: Re: [PATCH 0/3] Arm: dts: stm32: remove extra compatible uart string
> 
> Hi Vikas
> 
> 
> On 09/29/2017 12:51 AM, Vikas Manocha wrote:
> > stm32 uart driver is using two compatible strings "st,stm32-usart"
> > & "st,stm32-uart". One can be removed safely to save some space & time.
> >
> > Vikas Manocha (3):
> >    Arm: dts: stm32: remove extra compatible string for uart
> >    Arm: dts: stm32: remove extra compatible string from DT & driver
> >    ARM: dts: stm32h7: correct uart nodes compatible string
> >
> >   Documentation/devicetree/bindings/dma/stm32-dma.txt         |  2 +-
> >   Documentation/devicetree/bindings/serial/st,stm32-usart.txt | 10 +++-------
> >   arch/arm/boot/dts/stm32f429.dtsi                            | 12 ++++++------
> >   arch/arm/boot/dts/stm32f746.dtsi                            | 12 ++++++------
> >   arch/arm/boot/dts/stm32h743.dtsi                            |  4 ++--
> >   drivers/tty/serial/stm32-usart.c                            |  3 ---
> >   6 files changed, 18 insertions(+), 25 deletions(-)
> >
> 
> I think it is better to put people in CC of patch 1, 2, 3 also in CC of cover-letter.

I am not sure how to add relevant people in cover-letter, Get_maintainers script works for the patches  only.

> I think you should split patches differently. Maybe one
> for drivers and bindings (doc) updates. And others for DT updates.

Yes, it's like this only. First patch is DT binding & second is its implementation in the driver & stm32 device tree.

> 
> Conerning DT patches, all headers should start by "ARM: dts: stm32: blabla"

Yes, Same headers is used for the patch. You mean "arm" should be "ARM" ?

Cheers,
Vikas

> 
> Regards
> Alex