linux-kernel - Re: [PATCH 08/20] ARM: dts: sun4i: Change LRADC node names to avoid warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Oct 2017 11:26:35 +0200
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Chen-Yu Tsai <wens@...e.org>
Cc:     Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 08/20] ARM: dts: sun4i: Change LRADC node names to avoid
 warnings

On Thu, Oct 05, 2017 at 03:52:29PM +0000, Chen-Yu Tsai wrote:
> On Thu, Oct 5, 2017 at 6:49 PM, Maxime Ripard
> <maxime.ripard@...e-electrons.com> wrote:
> > One of the usage of the LRADC is to implement buttons. The bindings define
> > that we should have one subnode per button, with their associated voltage
> > as a property.
> >
> > However, there was no reg property but we still used the voltage associated
> > to the button as the unit-address, which eventually generated warnings in
> > DTC.
> >
> > Rename the node names to avoid those warnings.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> > ---
> >  arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts  |  6 +++---
> >  arch/arm/boot/dts/sun4i-a10-dserve-dsrv9703c.dts |  4 ++--
> >  arch/arm/boot/dts/sun4i-a10-gemei-g9.dts         |  6 +++---
> >  arch/arm/boot/dts/sun4i-a10-inet1.dts            |  6 +++---
> >  arch/arm/boot/dts/sun4i-a10-inet97fv2.dts        | 10 +++++-----
> >  arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts     | 10 +++++-----
> >  arch/arm/boot/dts/sun4i-a10-pov-protab2-ips9.dts |  4 ++--
> >  7 files changed, 23 insertions(+), 23 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts b/arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts
> > index 4978e46ca620..b2dbdac19c0f 100644
> > --- a/arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts
> > +++ b/arch/arm/boot/dts/sun4i-a10-chuwi-v7-cw0825.dts
> > @@ -98,21 +98,21 @@
> >         vref-supply = <&reg_vcc3v0>;
> >         status = "okay";
> >
> > -       button@800 {
> > +       button-800 {
> 
> I think 800mV-button would be better, i.e. have the "generic"
> part of the name as a suffix.

It would go against most of the convention that we have everywhere
else for framebuffers, pin muxings, or even regular node names that
start with the class, and then have the most specific part.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)