linux-kernel - Re: [PATCH 13/20] ARM: dts: sun4i: Remove gpio-keys warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 6 Oct 2017 11:27:57 +0200
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Chen-Yu Tsai <wens@...e.org>
Cc:     Mark Rutland <mark.rutland@....com>,
        Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 13/20] ARM: dts: sun4i: Remove gpio-keys warnings

On Thu, Oct 05, 2017 at 03:51:02PM +0000, Chen-Yu Tsai wrote:
> On Thu, Oct 5, 2017 at 6:49 PM, Maxime Ripard
> <maxime.ripard@...e-electrons.com> wrote:
> > Some gpio-keys definitions in our DTs were having buttons defined with a
> > unit-address and that would generate a DTC warning.
> >
> > Change the buttons node names to remove the warnings.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@...e-electrons.com>
> > ---
> >  arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts | 40 ++++++++++-----------
> >  arch/arm/boot/dts/sun4i-a10-pcduino.dts      |  6 +--
> >  2 files changed, 23 insertions(+), 23 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts b/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts
> > index 7c7f12132ea3..13224f5ac166 100644
> > --- a/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts
> > +++ b/arch/arm/boot/dts/sun4i-a10-inet9f-rev03.dts
> > @@ -67,7 +67,7 @@
> >                 #size-cells = <0>;
> >                 poll-interval = <20>;
> >
> > -               button@0 {
> > +               left-joystick-left {
> 
> Does this fit the naming scheme? Should we have "-button" suffices?

The example binding of gpio-keys just have the key name as node name,
just like most of the DT out there I could find.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)