linux-kernel - Re: [PATCH] block: remove unnecessary NULL checks in bioset_integrity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171006222629.GA30627@debian>
Date:   Fri, 6 Oct 2017 18:26:57 -0400
From:   Tim Hansen <devtimhansen@...il.com>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        alexander.levin@....verizon.com
Subject: Re: [PATCH] block: remove unnecessary NULL checks in
 bioset_integrity_free()

On Fri, Oct 06, 2017 at 01:04:25PM -0600, Jens Axboe wrote:
> On 10/05/2017 12:09 PM, Tim Hansen wrote:
> > mempool_destroy() already checks for a NULL value being passed in, this eliminates duplicate checks.
> > 
> > This was caught by running make coccicheck M=block/ on linus' tree on commit 77ede3a014a32746002f7889211f0cecf4803163 (current head as of this patch).
> 
> Applied, but I had to fix up your commit message. Please line wrap at
> 72 chars, otherwise it turns into an unreadable mess when people
> try to view them.
> 
> -- 
> Jens Axboe
> 

Noted! Thanks for the heads up on the char limit.