linux-kernel - Re: [PATCH] block: remove unnecessary NULL checks in bioset_integrity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 9 Oct 2017 14:34:18 -0400
From:   Kyle Fortin <kyle.fortin@...cle.com>
To:     Tim Hansen <devtimhansen@...il.com>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org, alexander.levin@....verizon.com
Subject: Re: [PATCH] block: remove unnecessary NULL checks in bioset_integrity_free()

On Oct 6, 2017, at 6:26 PM, Tim Hansen <devtimhansen@...il.com> wrote:
> On Fri, Oct 06, 2017 at 01:04:25PM -0600, Jens Axboe wrote:
>> On 10/05/2017 12:09 PM, Tim Hansen wrote:
>>> mempool_destroy() already checks for a NULL value being passed in, this eliminates duplicate checks.
>>> 
>>> This was caught by running make coccicheck M=block/ on linus' tree on commit 77ede3a014a32746002f7889211f0cecf4803163 (current head as of this patch).
>> 
>> Applied, but I had to fix up your commit message. Please line wrap at
>> 72 chars, otherwise it turns into an unreadable mess when people
>> try to view them.
>> 
>> -- 
>> Jens Axboe
>> 
> 
> Noted! Thanks for the heads up on the char limit.

scripts/checkpatch.pl would have caught it too

--
Kyle Fortin - Oracle Linux Engineering