linux-kernel - Re: powerpc: Always initialize input array when calling epapr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <3y8xjh6CPKz9t5C@ozlabs.org>
Date:   Sun,  8 Oct 2017 19:43:36 +1100 (AEDT)
From:   Michael Ellerman <patch-notifications@...erman.id.au>
To:     Seth Forshee <seth.forshee@...onical.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>
Cc:     Seth Forshee <seth.forshee@...onical.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: powerpc: Always initialize input array when calling epapr_hypercall()

On Thu, 2017-09-28 at 13:33:39 UTC, Seth Forshee wrote:
> Several callers to epapr_hypercall() pass an uninitialized stack
> allocated array for the input arguments, presumably because they
> have no input arguments. However this can produce errors like
> this one
> 
>  arch/powerpc/include/asm/epapr_hcalls.h:470:42: error: 'in' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>   unsigned long register r3 asm("r3") = in[0];
>                                         ~~^~~
> 
> Fix callers to this function to always zero-initialize the input
> arguments array to prevent this.
> 
> Signed-off-by: Seth Forshee <seth.forshee@...onical.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/186b8f1587c79c2fa04bfa392fdf08

cheers