linux-kernel - Re: selftests/powerpc: Use snprintf to construct DSCR sysfs interface paths

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <3y8xjj5K9Mz9t5R@ozlabs.org>
Date:   Sun,  8 Oct 2017 19:43:37 +1100 (AEDT)
From:   Michael Ellerman <patch-notifications@...erman.id.au>
To:     Seth Forshee <seth.forshee@...onical.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Shuah Khan <shuah@...nel.org>
Cc:     Seth Forshee <seth.forshee@...onical.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        linux-kselftest@...r.kernel.org
Subject: Re: selftests/powerpc: Use snprintf to construct DSCR sysfs interface paths

On Thu, 2017-09-28 at 13:34:26 UTC, Seth Forshee wrote:
> Currently sprintf is used, and while paths should never exceed
> the size of the buffer it is theoretically possible since
> dirent.d_name is 256 bytes. As a result this trips
> -Wformat-overflow, and since the test is built with -Wall -Werror
> the causes the build to fail. Switch to using snprintf and skip
> any paths which are too long for the filename buffer.
> 
> Signed-off-by: Seth Forshee <seth.forshee@...onical.com>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/06755a871314c7443a89c09650cdb3

cheers