linux-kernel - Re: [PATCH] linux/types.h: Restore the ability to disable sparse endianness checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171009162008-mutt-send-email-mst@kernel.org>
Date:   Mon, 9 Oct 2017 16:22:35 +0300
From:   "Michael S. Tsirkin" <mst@...hat.com>
To:     Bart Van Assche <bart.vanassche@....com>
Cc:     linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] linux/types.h: Restore the ability to disable sparse
 endianness checks

On Fri, Oct 06, 2017 at 10:23:53AM -0700, Bart Van Assche wrote:
> The purpose of patch "linux/types.h: enable endian checks for all
> sparse builds" was to encourage driver authors to annotate
> endianness correctly in their drivers. However, since that patch
> went upstream no endianness annotations in drivers have been fixed.
> I think that this shows that the followed approach does not work,
> probably because several driver authors do not use sparse. Restore
> the ability to disable sparse endianness checks such that it
> becomes again easy to review other sparse diagnostics for people
> who want to analyze drivers they are not the author of.
> 
> References: commit 05de97003c77 ("linux/types.h: enable endian checks for all sparse builds")
> Signed-off-by: Bart Van Assche <bart.vanassche@....com>
> Cc: Christoph Hellwig <hch@....de>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>

I still think the new default is good.  You probably want ability to
disable these checks selectively for the specific drivers though. Makes
it easier to spot what needs to be fixed.

> ---
>  include/uapi/linux/types.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/uapi/linux/types.h b/include/uapi/linux/types.h
> index 41e5914f0a8e..d3dcb0764c45 100644
> --- a/include/uapi/linux/types.h
> +++ b/include/uapi/linux/types.h
> @@ -23,7 +23,11 @@
>  #else
>  #define __bitwise__
>  #endif
> +#if !defined(__CHECK_ENDIAN__) || __CHECK_ENDIAN__ != 0
>  #define __bitwise __bitwise__
> +#else
> +#define __bitwise
> +#endif
>  
>  typedef __u16 __bitwise __le16;
>  typedef __u16 __bitwise __be16;
> -- 
> 2.14.2