linux-kernel - Re: [PATCH] thunderbolt: Initialize Thunderbolt bus earlier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171009.103057.2069299695410118368.davem@davemloft.net>
Date:   Mon, 09 Oct 2017 10:30:57 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     mika.westerberg@...ux.intel.com
Cc:     andreas.noever@...il.com, michael.jamet@...el.com,
        yehezkel.bernat@...el.com, fengguang.wu@...el.com,
        gregkh@...uxfoundation.org, andriy.shevchenko@...ux.intel.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thunderbolt: Initialize Thunderbolt bus earlier

From: Mika Westerberg <mika.westerberg@...ux.intel.com>
Date: Mon,  9 Oct 2017 16:22:34 +0300

> The 0day kbuild robot reports following crash:
 ...
> The reason is that both Thunderbolt bus and thunderbolt-net are build
> into the kernel image, and the latter is linked first because
> drivers/net comes before drivers/thunderbolt. Since both use
> module_init() thunderbolt-net ends up calling Thunderbolt bus functions
> too early triggering the above crash.
> 
> Fix this by moving Thunderbolt bus initialization to happen earlier to
> make sure all the data structures are ready when Thunderbolt service
> drivers are initialized. To be on the safe side also add a check for
> properly initialized xdomain_property_dir to tb_register_property_dir().
> 
> Reported-by: kernel test robot <fengguang.wu@...el.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Applied to net-next, thanks.