linux-kernel - Re: [PATCH] skd: Use kmem_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1507570433.2674.18.camel@wdc.com>
Date:   Mon, 9 Oct 2017 17:33:54 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "himanshujha199640@...il.com" <himanshujha199640@...il.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>
Subject: Re: [PATCH] skd: Use kmem_cache_free

On Mon, 2017-10-09 at 03:00 +0530, Himanshu Jha wrote:
> Use kmem_cache_free instead of kfree for freeing the memory previously
> allocated with kmem_cache_zalloc/kmem_cache_alloc/kmem_cache_node.
> 
> Signed-off-by: Himanshu Jha <himanshujha199640@...il.com>
> ---
>  drivers/block/skd_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c
> index 7cedb42..64d0fc1 100644
> --- a/drivers/block/skd_main.c
> +++ b/drivers/block/skd_main.c
> @@ -2604,7 +2604,7 @@ static void *skd_alloc_dma(struct skd_device *skdev, struct kmem_cache *s,
>  		return NULL;
>  	*dma_handle = dma_map_single(dev, buf, s->size, dir);
>  	if (dma_mapping_error(dev, *dma_handle)) {
> -		kfree(buf);
> +		kmem_cache_free(s, buf);
>  		buf = NULL;
>  	}
>  	return buf;

Thanks for this patch.

Reviewed-by: Bart Van Assche <bart.vanassche@....com>