linux-kernel - Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Oct 2017 08:44:23 -0700
From:   Michael Lyle <mlyle@...e.org>
To:     Coly Li <i@...y.li>, Liang Chen <liangchen.linux@...il.com>,
        linux-bcache@...r.kernel.org
Cc:     kent.overstreet@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

On 10/10/2017 05:25 AM, Coly Li wrote:
> On 2017/10/10 下午5:00, Liang Chen wrote:
>> mutex_destroy does nothing most of time, but it's better to call
>> it to make the code future proof and it also has some meaning
>> for like mutex debug.
>>
>> As Coly pointed out in a previous review, bcache_exit() may not be
>> able to handle all the references properly if userspace registers
>> cache and backing devices right before bch_debug_init runs and
>> bch_debug_init failes later. So not exposing userspace interface
>> until everything is ready to avoid that issue.
>>
>> Signed-off-by: Liang Chen <liangchen.linux@...il.com>
> 
> Hi Liang,
> 
> No more comment from me, it looks good. Thanks.
> 
> Reviewed-by: Coly Li <colyli@...e.de>

Looks good to me too.

Reviewed-by: Michael Lyle <mlyle@...e.org>