linux-kernel - Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.11.1710271903590.24585@mail.ewheeler.net>
Date:   Fri, 27 Oct 2017 19:05:45 +0000 (UTC)
From:   Eric Wheeler <bcache@...ts.ewheeler.net>
To:     Michael Lyle <mlyle@...e.org>
cc:     Coly Li <i@...y.li>, Liang Chen <liangchen.linux@...il.com>,
        linux-bcache@...r.kernel.org, kent.overstreet@...il.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] bcache: explicitly destroy mutex while exiting

On Tue, 10 Oct 2017, Michael Lyle wrote:

> On 10/10/2017 05:25 AM, Coly Li wrote:
> > On 2017/10/10 下午5:00, Liang Chen wrote:
> >> mutex_destroy does nothing most of time, but it's better to call
> >> it to make the code future proof and it also has some meaning
> >> for like mutex debug.
> >>
> >> As Coly pointed out in a previous review, bcache_exit() may not be
> >> able to handle all the references properly if userspace registers
> >> cache and backing devices right before bch_debug_init runs and
> >> bch_debug_init failes later. So not exposing userspace interface
> >> until everything is ready to avoid that issue.
> >>
> >> Signed-off-by: Liang Chen <liangchen.linux@...il.com>
> > 
> > Hi Liang,
> > 
> > No more comment from me, it looks good. Thanks.
> > 
> > Reviewed-by: Coly Li <colyli@...e.de>
> 
> Looks good to me too.
> 
> Reviewed-by: Michael Lyle <mlyle@...e.org>

Should this Cc: stable to avoid the register race (possible 
crash?) described by Liang in other stable kernels?

Reviewed-by: Eric Wheeler <bcache@...ux.ewheeler.net>

> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>