linux-kernel - Re: [PATCH][drm-next] drm/amdgpu: make function uvd_v6_0_enc_get_destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <169aed1d-f068-9ae1-1de0-eb14afae3991@gmail.com>
Date:   Wed, 11 Oct 2017 12:41:23 +0200
From:   Christian König <ckoenig.leichtzumerken@...il.com>
To:     Colin King <colin.king@...onical.com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Airlie <airlied@...ux.ie>, Rex Zhu <Rex.Zhu@....com>,
        James Zhu <James.Zhu@....com>,
        Ken Wang <Qingqing.Wang@....com>,
        amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][drm-next] drm/amdgpu: make function
 uvd_v6_0_enc_get_destroy_msg static

Am 11.10.2017 um 11:21 schrieb Colin King:
> From: Colin Ian King <colin.king@...onical.com>
>
> The function uvd_v6_0_enc_get_destroy_msg is local to the source and
> does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'uvd_v6_0_enc_get_destroy_msg' was not declared. Should it be
> static?
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Christian König <christian.koenig@....com>

> ---
>   drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
> index 60af7310a234..71299c67c517 100644
> --- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
> @@ -268,8 +268,9 @@ static int uvd_v6_0_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t handle
>    *
>    * Close up a stream for HW test or if userspace failed to do so
>    */
> -int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle,
> -				 bool direct, struct dma_fence **fence)
> +static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring,
> +					uint32_t handle,
> +					bool direct, struct dma_fence **fence)
>   {
>   	const unsigned ib_size_dw = 16;
>   	struct amdgpu_job *job;