linux-kernel - Re: [PATCH][drm-next] drm/amdgpu: make function uvd_v6_0_enc_get_destroy_msg static

Open Source and information security mailing list archives

Message-ID: <CADnq5_MzW8_=OyYGvH7xQQKLu-00Pi9mCH3SuiVP2+QxVDymXg@mail.gmail.com>
Date:   Wed, 11 Oct 2017 12:28:17 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Christian Koenig <christian.koenig@....com>
Cc:     Colin King <colin.king@...onical.com>,
        Alex Deucher <alexander.deucher@....com>,
        David Airlie <airlied@...ux.ie>, Rex Zhu <Rex.Zhu@....com>,
        James Zhu <James.Zhu@....com>,
        Ken Wang <Qingqing.Wang@....com>,
        amd-gfx list <amd-gfx@...ts.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@...ts.freedesktop.org>, kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][drm-next] drm/amdgpu: make function uvd_v6_0_enc_get_destroy_msg
 static

On Wed, Oct 11, 2017 at 6:41 AM, Christian König
<ckoenig.leichtzumerken@...il.com> wrote:
> Am 11.10.2017 um 11:21 schrieb Colin King:
>>
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> The function uvd_v6_0_enc_get_destroy_msg is local to the source and
>> does not need to be in global scope, so make it static.
>>
>> Cleans up sparse warning:
>> symbol 'uvd_v6_0_enc_get_destroy_msg' was not declared. Should it be
>> static?
>>
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>
>
> Reviewed-by: Christian König <christian.koenig@....com>
>

Applied.  thanks!

Alex

>> ---
>>   drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> index 60af7310a234..71299c67c517 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> @@ -268,8 +268,9 @@ static int uvd_v6_0_enc_get_create_msg(struct
>> amdgpu_ring *ring, uint32_t handle
>>    *
>>    * Close up a stream for HW test or if userspace failed to do so
>>    */
>> -int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t
>> handle,
>> -                                bool direct, struct dma_fence **fence)
>> +static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring,
>> +                                       uint32_t handle,
>> +                                       bool direct, struct dma_fence
>> **fence)
>>   {
>>         const unsigned ib_size_dw = 16;
>>         struct amdgpu_job *job;
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives