linux-kernel - Re: [PATCH][dma-next] dmaengine: stm32: remove redundant initialization of hwdesc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 Oct 2017 14:16:28 +0200
From:   Pierre Yves MORDRET <pierre-yves.mordret@...com>
To:     Colin King <colin.king@...onical.com>,
        Vinod Koul <vinod.koul@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        <dmaengine@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][dma-next] dmaengine: stm32: remove redundant
 initialization of hwdesc


On 10/11/2017 12:28 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> hwdesc is being initialized to desc->hwdesc but this is never read
> as hwdesc is overwritten in a for-loop.  Remove the redundant
> initialization and move the declaration of hwdesc into the for-loop.
> 
> Cleans up clang warning:
> Value stored to 'hwdesc' during its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/dma/stm32-mdma.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c
> index 0db59a7e80e0..d3be6bffdf12 100644
> --- a/drivers/dma/stm32-mdma.c
> +++ b/drivers/dma/stm32-mdma.c
> @@ -1252,13 +1252,13 @@ static size_t stm32_mdma_desc_residue(struct stm32_mdma_chan *chan,
>  				      u32 curr_hwdesc)
>  {
>  	struct stm32_mdma_device *dmadev = stm32_mdma_get_dev(chan);
> -	struct stm32_mdma_hwdesc *hwdesc = desc->hwdesc;
>  	u32 cbndtr, residue, modulo, burst_size;
>  	int i;
>  
>  	residue = 0;
>  	for (i = curr_hwdesc + 1; i < desc->count; i++) {
> -		hwdesc = &desc->hwdesc[i];
> +		struct stm32_mdma_hwdesc *hwdesc = &desc->hwdesc[i];
> +
>  		residue += STM32_MDMA_CBNDTR_BNDT(hwdesc->cbndtr);
>  	}
>  	cbndtr = stm32_mdma_read(dmadev, STM32_MDMA_CBNDTR(chan->id));
> 

Acked-by: Pierre-Yves MORDRET <pierre-yves.mordret@...com>