linux-kernel - Re: [PATCH for-next] IB,hfi1 Add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d7e8d05-9a6b-6dbf-d528-41ba64129348@intel.com>
Date:   Wed, 11 Oct 2017 11:31:18 -0400
From:   Dennis Dalessandro <dennis.dalessandro@...el.com>
To:     Thomas Bogendoerfer <tbogendoerfer@...e.de>,
        Mike Marciniszyn <mike.marciniszyn@...el.com>,
        Doug Ledford <dledford@...hat.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-next] IB,hfi1 Add MODULE_FIRMWARE statements

On 10/11/2017 8:41 AM, Thomas Bogendoerfer wrote:
> Provide information about used firmware files via modinfo.
> 
> Signed-off-by: Thomas Bogendoerfer <tbogendoerfer@...e.de>
> ---
>   drivers/infiniband/hw/hfi1/firmware.c | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/infiniband/hw/hfi1/firmware.c b/drivers/infiniband/hw/hfi1/firmware.c
> index dee3c674f33d..f56ace76b42c 100644
> --- a/drivers/infiniband/hw/hfi1/firmware.c
> +++ b/drivers/infiniband/hw/hfi1/firmware.c
> @@ -70,6 +70,11 @@
>   #define ALT_FW_PCIE_NAME "hfi1_pcie_d.fw"
>   #define HOST_INTERFACE_VERSION 1
>   
> +MODULE_FIRMWARE(DEFAULT_FW_8051_NAME_ASIC);
> +MODULE_FIRMWARE(DEFAULT_FW_FABRIC_NAME);
> +MODULE_FIRMWARE(DEFAULT_FW_SBUS_NAME);
> +MODULE_FIRMWARE(DEFAULT_FW_PCIE_NAME);
> +
>   static uint fw_8051_load = 1;
>   static uint fw_fabric_serdes_load = 1;
>   static uint fw_pcie_serdes_load = 1;
> 

I don't find this terribly useful, but if it's useful for you I'm sure 
it is for others as well, so I have no problem with it.

Reviewed-by: Dennis Dalessandro <dennis.dalessandro@...el.com>