linux-kernel - Re: [PATCH] drm: Fix return value check in kirin_drm_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171011173028.lvtwcs7sbc5eqo44@art_vandelay>
Date:   Wed, 11 Oct 2017 13:30:28 -0400
From:   Sean Paul <seanpaul@...omium.org>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Xinliang Liu <z.liuxinliang@...ilicon.com>, zourongrong@...il.com,
        kong.kongxinwei@...ilicon.com, puck.chen@...ilicon.com,
        airlied@...ux.ie, robh@...nel.org, rmk+kernel@...linux.org.uk,
        treding@...dia.com, arnd@...db.de, daniel.vetter@...ll.ch,
        seanpaul@...omium.org, krisman@...labora.co.uk, jsarha@...com,
        noralf@...nnes.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: Fix return value check in kirin_drm_platform_probe()

On Wed, Oct 11, 2017 at 11:17:16AM +0000, Wei Yongjun wrote:
> In case of error, the function of_graph_get_remote_node() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test..
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>

Reviewed-by: Sean Paul <seanpaul@...omium.org>

> ---
>  drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> index e27352c..527aa58 100644
> --- a/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> +++ b/drivers/gpu/drm/hisilicon/kirin/kirin_drm_drv.c
> @@ -236,8 +236,8 @@ static int kirin_drm_platform_probe(struct platform_device *pdev)
>  	}
>  
>  	remote = of_graph_get_remote_node(np, 0, 0);
> -	if (IS_ERR(remote))
> -		return PTR_ERR(remote);
> +	if (!remote)
> +		return -ENODEV;
>  
>  	drm_of_component_match_add(dev, &match, compare_of, remote);
>  	of_node_put(remote);
> 
> 
> 

-- 
Sean Paul, Software Engineer, Google / Chromium OS