linux-kernel - Re: [PATCH] drm: Fix return value check in kirin_drm_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wp40oon4.fsf@dilma.collabora.co.uk>
Date:   Thu, 12 Oct 2017 03:39:59 -0300
From:   Gabriel Krisman Bertazi <krisman@...labora.co.uk>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Xinliang Liu <z.liuxinliang@...ilicon.com>,
        <zourongrong@...il.com>, <kong.kongxinwei@...ilicon.com>,
        <puck.chen@...ilicon.com>, <airlied@...ux.ie>, <robh@...nel.org>,
        <rmk+kernel@...linux.org.uk>, <treding@...dia.com>,
        <arnd@...db.de>, <daniel.vetter@...ll.ch>, <seanpaul@...omium.org>,
        <jsarha@...com>, <noralf@...nnes.org>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: Fix return value check in kirin_drm_platform_probe()

Wei Yongjun <weiyongjun1@...wei.com> writes:

> In case of error, the function of_graph_get_remote_node() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test..

Looks good.

Reviewed-by: Gabriel Krisman Bertazi <krisman@...labora.co.uk>

-- 
Gabriel Krisman Bertazi