linux-kernel - Re: [PATCH] drm: Fix return value check in kirin_drm_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 Oct 2017 10:42:55 -0400
From:   Sean Paul <seanpaul@...omium.org>
To:     Gabriel Krisman Bertazi <krisman@...labora.co.uk>
Cc:     Wei Yongjun <weiyongjun1@...wei.com>,
        Xinliang Liu <z.liuxinliang@...ilicon.com>,
        Rongrong Zou <zourongrong@...il.com>,
        Xinwei Kong <kong.kongxinwei@...ilicon.com>,
        Chen Feng <puck.chen@...ilicon.com>,
        Dave Airlie <airlied@...ux.ie>, Rob Herring <robh@...nel.org>,
        Russell King <rmk+kernel@...linux.org.uk>,
        Thierry Reding <treding@...dia.com>,
        Arnd Bergmann <arnd@...db.de>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Jyri Sarha <jsarha@...com>, noralf@...nnes.org,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] drm: Fix return value check in kirin_drm_platform_probe()

On Thu, Oct 12, 2017 at 2:39 AM, Gabriel Krisman Bertazi
<krisman@...labora.co.uk> wrote:
> Wei Yongjun <weiyongjun1@...wei.com> writes:
>
>> In case of error, the function of_graph_get_remote_node() returns NULL
>> pointer not ERR_PTR(). The IS_ERR() test in the return value check
>> should be replaced with NULL test..
>
> Looks good.
>
> Reviewed-by: Gabriel Krisman Bertazi <krisman@...labora.co.uk>
>

FYI, I just noticed Dan Carpenter sent an identical patch last week
"<20171005125751.jvtjms62vbtxuvak@...nda> [PATCH] drm/kirin: Checking
for IS_ERR() instead of NULL".

I'll add my R-b there, since it was first.

Sean


> --
> Gabriel Krisman Bertazi