linux-kernel - Re: [PATCH] rtc: jz4740: fix loading of rtc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171012123251.e6jengn5vvmoxzr4@piout.net>
Date:   Thu, 12 Oct 2017 14:32:51 +0200
From:   Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Ralf Baechle <ralf@...ux-mips.org>,
        Alex Smith <alex.smith@...tec.com>,
        Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: jz4740: fix loading of rtc driver

On 18/09/2017 at 21:10:13 +0200, Mathieu Malaterre wrote:
> The current timeout for waiting for WRDY is not always sufficient. Always
> increase it to 10000 even on JZ4740. This is technically only required on
> JZ4780, where the current symptoms seen after a hard reboot are:
> 
>   jz4740-rtc 10003000.rtc: rtc core: registered 10003000.rtc as rtc0
>   jz4740-rtc 10003000.rtc: Could not write to RTC registers
>   jz4740-rtc: probe of 10003000.rtc failed with error -5
> 
> Suggested-by: Alex Smith <alex.smith@...tec.com>
> Cc: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@...tec.com>
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> ---
>  drivers/rtc/rtc-jz4740.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com