linux-kernel - Re: [PATCH] dlm: make config_item

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOH+1jGsRu8FVz1baHFG+G-yPsXp1do72RMtjHZH2mmk_DL=sA@mail.gmail.com>
Date:   Thu, 12 Oct 2017 17:03:02 +0200
From:   Bhumika Goyal <bhumirks@...il.com>
To:     Julia Lawall <julia.lawall@...6.fr>, ccaulfie@...hat.com,
        teigland@...hat.com, cluster-devel@...hat.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:     Bhumika Goyal <bhumirks@...il.com>
Subject: Re: [PATCH] dlm: make config_item_type const

On Thu, Oct 12, 2017 at 3:22 PM, Bhumika Goyal <bhumirks@...il.com> wrote:
> This is a followup patch for:
> https://patchwork.kernel.org/patch/9999649/ and
> https://lkml.org/lkml/2017/10/11/375
>
> Make config_item_type structures const as they are either passed to a
> function having the argument as const or stored in the const "ci_type"
> field of a config_item structure.
>
> Done using Coccinelle.
>

Actually, this patch is dependent on the patches in the links
https://lkml.org/lkml/2017/10/11/375 and
https://patchwork.kernel.org/patch/9999649/. Therefore, this patch
won't be correct unless the patches in these links gets applied.

> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> ---
>  fs/dlm/config.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/fs/dlm/config.c b/fs/dlm/config.c
> index 7211e82..1270551 100644
> --- a/fs/dlm/config.c
> +++ b/fs/dlm/config.c
> @@ -282,44 +282,44 @@ struct dlm_node {
>         .release = release_node,
>  };
>
> -static struct config_item_type clusters_type = {
> +static const struct config_item_type clusters_type = {
>         .ct_group_ops = &clusters_ops,
>         .ct_owner = THIS_MODULE,
>  };
>
> -static struct config_item_type cluster_type = {
> +static const struct config_item_type cluster_type = {
>         .ct_item_ops = &cluster_ops,
>         .ct_attrs = cluster_attrs,
>         .ct_owner = THIS_MODULE,
>  };
>
> -static struct config_item_type spaces_type = {
> +static const struct config_item_type spaces_type = {
>         .ct_group_ops = &spaces_ops,
>         .ct_owner = THIS_MODULE,
>  };
>
> -static struct config_item_type space_type = {
> +static const struct config_item_type space_type = {
>         .ct_item_ops = &space_ops,
>         .ct_owner = THIS_MODULE,
>  };
>
> -static struct config_item_type comms_type = {
> +static const struct config_item_type comms_type = {
>         .ct_group_ops = &comms_ops,
>         .ct_owner = THIS_MODULE,
>  };
>
> -static struct config_item_type comm_type = {
> +static const struct config_item_type comm_type = {
>         .ct_item_ops = &comm_ops,
>         .ct_attrs = comm_attrs,
>         .ct_owner = THIS_MODULE,
>  };
>
> -static struct config_item_type nodes_type = {
> +static const struct config_item_type nodes_type = {
>         .ct_group_ops = &nodes_ops,
>         .ct_owner = THIS_MODULE,
>  };
>
> -static struct config_item_type node_type = {
> +static const struct config_item_type node_type = {
>         .ct_item_ops = &node_ops,
>         .ct_attrs = node_attrs,
>         .ct_owner = THIS_MODULE,
> --
> 1.9.1
>