linux-kernel - Re: [PATCH] usb: gadget: configfs: make config_item

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOH+1jH7we3TSJ-_JTbMA_5K=p7Rff6sGpDrHL+PgDZ4UqHOpw@mail.gmail.com>
Date:   Thu, 12 Oct 2017 17:03:19 +0200
From:   Bhumika Goyal <bhumirks@...il.com>
To:     Julia Lawall <julia.lawall@...6.fr>, balbi@...nel.org,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:     Bhumika Goyal <bhumirks@...il.com>
Subject: Re: [PATCH] usb: gadget: configfs: make config_item_type const

On Thu, Oct 12, 2017 at 3:03 PM, Bhumika Goyal <bhumirks@...il.com> wrote:
> This is a followup patch for:
> https://patchwork.kernel.org/patch/9999649/ and
> https://lkml.org/lkml/2017/10/11/375
>
> Make config_item_type structures const as they are either passed to a
> function having the argument as const or stored in the const "ci_type"
> field of a config_item structure.
>
> Done using Coccinelle.
>

Actually, this patch is dependent on the patches in the links
https://lkml.org/lkml/2017/10/11/375 and
https://patchwork.kernel.org/patch/9999649/. Therefore, this patch
won't be correct unless the patches in these links gets applied.

> Signed-off-by: Bhumika Goyal <bhumirks@...il.com>
> ---
>  drivers/usb/gadget/configfs.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/gadget/configfs.c b/drivers/usb/gadget/configfs.c
> index a22a892..c90a266 100644
> --- a/drivers/usb/gadget/configfs.c
> +++ b/drivers/usb/gadget/configfs.c
> @@ -505,13 +505,13 @@ static ssize_t gadget_config_desc_bmAttributes_store(struct config_item *item,
>         NULL,
>  };
>
> -static struct config_item_type gadget_config_type = {
> +static const struct config_item_type gadget_config_type = {
>         .ct_item_ops    = &gadget_config_item_ops,
>         .ct_attrs       = gadget_config_attrs,
>         .ct_owner       = THIS_MODULE,
>  };
>
> -static struct config_item_type gadget_root_type = {
> +static const struct config_item_type gadget_root_type = {
>         .ct_item_ops    = &gadget_root_item_ops,
>         .ct_attrs       = gadget_root_attrs,
>         .ct_owner       = THIS_MODULE,
> @@ -593,7 +593,7 @@ static void function_drop(
>         .drop_item      = &function_drop,
>  };
>
> -static struct config_item_type functions_type = {
> +static const struct config_item_type functions_type = {
>         .ct_group_ops   = &functions_ops,
>         .ct_owner       = THIS_MODULE,
>  };
> @@ -694,7 +694,7 @@ static void config_desc_drop(
>         .drop_item      = &config_desc_drop,
>  };
>
> -static struct config_item_type config_desc_type = {
> +static const struct config_item_type config_desc_type = {
>         .ct_group_ops   = &config_desc_ops,
>         .ct_owner       = THIS_MODULE,
>  };
> @@ -1475,7 +1475,7 @@ static void gadgets_drop(struct config_group *group, struct config_item *item)
>         .drop_item      = &gadgets_drop,
>  };
>
> -static struct config_item_type gadgets_type = {
> +static const struct config_item_type gadgets_type = {
>         .ct_group_ops   = &gadgets_ops,
>         .ct_owner       = THIS_MODULE,
>  };
> --
> 1.9.1
>