linux-kernel - Re: [PATCH 4.9 000/105] 4.9.55-stable review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171012.101659.654720543467651527.davem@davemloft.net>
Date:   Thu, 12 Oct 2017 10:16:59 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     andreas.radke@...lbox.org, shuahkh@....samsung.com,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
        linux@...ck-us.net, patches@...nelci.org,
        ben.hutchings@...ethink.co.uk, stable@...r.kernel.org
Subject: Re: [PATCH 4.9 000/105] 4.9.55-stable review

From: Xin Long <lucien.xin@...il.com>
Date: Thu, 12 Oct 2017 23:25:10 +0800

> pls try revert:
> commit 02f7e4101092b88e57c73171174976c8a72a3eba
> Author: Eric Dumazet <edumazet@...gle.com>
> Date:   Mon Oct 2 12:20:51 2017 -0700
> 
>     socket, bpf: fix possible use after free
> 
> which caused a obvious issue in __sk_attach_prog():
>         atomic_set(&fp->refcnt, 0);  <----
> 
>         if (!sk_filter_charge(sk, fp)) {
>                 kfree(fp);
>                 return -ENOMEM;
>         }

Yeah this is the bad patch, my backport was buggy.

Greg, please revert.