linux-kernel - Re: [PATCH] tracing: Remove unused clock events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 13 Oct 2017 09:20:44 +0200
From:   Jean Pihet <jean.pihet@...oldbits.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, discuss@...swatts.org,
        Linux PM list <linux-pm@...r.kernel.org>,
        Thomas Renninger <trenn@...e.de>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Len Brown <len.brown@...el.com>,
        Kevin Hilman <khilman@...prootsystems.com>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] tracing: Remove unused clock events

Hi Steven,

On Thu, Oct 12, 2017 at 6:44 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
>
> [ Resending again, including linux-pm@...r.kernel.org this time ]
>
> From: Steven Rostedt (VMware) <rostedt@...dmis.org>
>
> Commit 74704ac6 ("tracing, perf: Add more power related events") added
> new events, among them were trace_clock_enable, trace_clock_disable and
> trace_clock_set_rate. In the last 7 years, nothing has used them. As
> they take up space, and nobody cares about these events, remove them.

Ok if it is not used. Can others confirm?

AFAIK this has been used internally.

BR,
Jean

>
> Signed-off-by: Steven Rostedt (VMware) <rostedt@...dmis.org>
> ---
> diff --git a/include/trace/events/power.h b/include/trace/events/power.h
> index 54e3aad..d900cb7 100644
> --- a/include/trace/events/power.h
> +++ b/include/trace/events/power.h
> @@ -254,53 +254,6 @@ DEFINE_EVENT(wakeup_source,
> wakeup_source_deactivate, );
>
>  /*
> - * The clock events are used for clock enable/disable and for
> - *  clock rate change
> - */
> -DECLARE_EVENT_CLASS(clock,
> -
> -       TP_PROTO(const char *name, unsigned int state, unsigned int
> cpu_id), -
> -       TP_ARGS(name, state, cpu_id),
> -
> -       TP_STRUCT__entry(
> -               __string(       name,           name            )
> -               __field(        u64,            state           )
> -               __field(        u64,            cpu_id          )
> -       ),
> -
> -       TP_fast_assign(
> -               __assign_str(name, name);
> -               __entry->state = state;
> -               __entry->cpu_id = cpu_id;
> -       ),
> -
> -       TP_printk("%s state=%lu cpu_id=%lu", __get_str(name),
> -               (unsigned long)__entry->state, (unsigned
> long)__entry->cpu_id) -);
> -
> -DEFINE_EVENT(clock, clock_enable,
> -
> -       TP_PROTO(const char *name, unsigned int state, unsigned int
> cpu_id), -
> -       TP_ARGS(name, state, cpu_id)
> -);
> -
> -DEFINE_EVENT(clock, clock_disable,
> -
> -       TP_PROTO(const char *name, unsigned int state, unsigned int
> cpu_id), -
> -       TP_ARGS(name, state, cpu_id)
> -);
> -
> -DEFINE_EVENT(clock, clock_set_rate,
> -
> -       TP_PROTO(const char *name, unsigned int state, unsigned int
> cpu_id), -
> -       TP_ARGS(name, state, cpu_id)
> -);
> -
> -/*
>   * The power domain events are used for power domains transitions
>   */
>  DECLARE_EVENT_CLASS(power_domain,