linux-kernel - Re: [PATCH] tracing: Remove unused clock events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171013102553.4e954f27@gandalf.local.home>
Date:   Fri, 13 Oct 2017 10:25:53 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Jean Pihet <jean.pihet@...oldbits.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, discuss@...swatts.org,
        Linux PM list <linux-pm@...r.kernel.org>,
        Thomas Renninger <trenn@...e.de>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Len Brown <len.brown@...el.com>,
        Kevin Hilman <khilman@...prootsystems.com>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] tracing: Remove unused clock events

On Fri, 13 Oct 2017 09:20:44 +0200
Jean Pihet <jean.pihet@...oldbits.com> wrote:

> Hi Steven,
> 
> On Thu, Oct 12, 2017 at 6:44 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> >
> > [ Resending again, including linux-pm@...r.kernel.org this time ]
> >
> > From: Steven Rostedt (VMware) <rostedt@...dmis.org>
> >
> > Commit 74704ac6 ("tracing, perf: Add more power related events") added
> > new events, among them were trace_clock_enable, trace_clock_disable and
> > trace_clock_set_rate. In the last 7 years, nothing has used them. As
> > they take up space, and nobody cares about these events, remove them.  
> 
> Ok if it is not used. Can others confirm?
> 
> AFAIK this has been used internally.

If it has been used internally, then the events should be defined
internally. The trace event hooks are not there, there's no reason to
define events were hooks are not present. There's no advantage for
keeping them in the kernel proper.

-- Steve